PURE plugin fix & warn on load error #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…autoRender() with directives leads to unexpected results.
Before the fix, this test case results in the error "The node
.summary-text" was not found in the template" being printed to the
console and the template not being processed as expected.
<!DOCTYPE html>
<html>
<head>
<script type="text/javascript" src="js/jquery.min.js"></script>
<script type="text/javascript" src="js/pure.js"></script>
<script type="text/javascript" src="js/sammy/sammy.js"></script>
<script type="text/javascript" src="js/sammy/plugins/sammy.pure.js"></script>
<script type="text/javascript">
var app = $.sammy('#main', function() {
this.use('Pure');
this.get('#/', function(context) {
var data = {
summary: 'buy bread',
state: 'done'
};
var directives = {
'.summary-text': 'summary',
'.state': 'state'
};
context.pure('#main', data, directives);
});
});
$(document).ready(function() {
app.run('#/');
});
</script>
</head>
<body>
<div id="main">
<div class="summary">[<span class="state"></span>] <span class="summary-text"></span></div>
</div>
</body>
</html>
…because of JSON parse error).
Example:
this.get('#/foo/bar', function(context) {
// business as usual
}, function() {
// run when user navigates away from #/foo/bar
// useful e.g. to undo anything specific to the #/foo/bar view
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with a couple of issues that bit me on my first day with SammyJS.
The second is more of a beginning of a fix (I haven't looked into Sammy's own logging facilities yet).